Skip to content

Fix Fomantic's line-height causing vertical scrollbars to appear #26961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 11 commits into from
Sep 13, 2023
Merged

Fix Fomantic's line-height causing vertical scrollbars to appear #26961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a7e49fe
Fix UI anomalies
kerwin612 Sep 7, 2023
cf34473
Adjusted as @silverwind suggested
kerwin612 Sep 8, 2023
f99c201
Merge branch 'main' into patch-2
kerwin612 Sep 8, 2023
0fa29b5
Merge branch 'main' into patch-2
kerwin612 Sep 9, 2023
a495f3a
Adjusted as @wxiaoguang suggested
kerwin612 Sep 9, 2023
600f1ac
Merge branch 'main' into patch-2
kerwin612 Sep 12, 2023
24c1f6b
Merge branch 'main' into patch-2
kerwin612 Sep 12, 2023
42647fb
Merge branch 'main' into patch-2
kerwin612 Sep 13, 2023
bbb20af
Adjusted as @wxiaoguang suggested
kerwin612 Sep 13, 2023
2651757
Merge branch 'patch-2' of github.com:kerwin612/gitea into patch-2
kerwin612 Sep 13, 2023
3126333
Merge branch 'main' into patch-2
GiteaBot Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion templates/repo/settings/webhook/base_list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@
{{range .Webhooks}}
<div class="item truncated-item-container">
<span class="text {{if eq .LastStatus 1}}green{{else if eq .LastStatus 2}}red{{else}}grey{{end}} gt-mr-3">{{svg "octicon-dot-fill" 22}}</span>
<a class="text truncate gt-f1 gt-mr-3" title="{{.URL}}" href="{{$.BaseLink}}/{{.ID}}">{{.URL}}</a>
<div class="text truncate gt-f1 gt-mr-3">
<a title="{{.URL}}" href="{{$.BaseLink}}/{{.ID}}">{{.URL}}</a>
</div>
<a class="muted gt-p-3" href="{{$.BaseLink}}/{{.ID}}">{{svg "octicon-pencil"}}</a>
<a class="delete-button gt-p-3" data-url="{{$.Link}}/delete" data-id="{{.ID}}">{{svg "octicon-trash"}}</a>
</div>
Expand Down
8 changes: 8 additions & 0 deletions web_src/css/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,14 @@ a.label,
text-align: start; /* Override fomantic's `text-align: left` to make RTL work via HTML `dir="auto"` */
}

/* fix Fomantic's line-height causing vertical scrollbars to appear */
ul.ui.list li,
ol.ui.list li,
.ui.list > .item,
.ui.list .list > .item {
line-height: var(--line-height-default);
}

.ui.input.focus > input,
.ui.input > input:focus {
border-color: var(--color-primary);
Expand Down