Skip to content

Improve show role #26621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Improve show role #26621

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cddba67
improve
yp05327 Aug 21, 2023
e266ba2
fix lint
yp05327 Aug 21, 2023
1369ace
Merge branch 'main' into improve-show-role
GiteaBot Aug 21, 2023
17f7ae9
Merge branch 'main' into improve-show-role
GiteaBot Aug 21, 2023
0984d6a
Merge branch 'main' into improve-show-role
GiteaBot Aug 21, 2023
9ecdc7f
Merge branch 'main' into improve-show-role
yp05327 Aug 22, 2023
f30e182
use ctx.Locale
yp05327 Aug 22, 2023
e190e12
add role-label
yp05327 Aug 22, 2023
593b703
Merge branch 'main' into improve-show-role
GiteaBot Aug 22, 2023
79a66b9
Merge branch 'main' into improve-show-role
GiteaBot Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions templates/repo/issue/view_content.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,7 @@
{{end}}
</div>
<div class="comment-header-right actions gt-df gt-ac">
{{if gt .Issue.ShowRole 0}}
{{if (.Issue.ShowRole.HasRole "Writer")}}
<div class="ui basic label role-label">
{{$.locale.Tr "repo.issues.collaborator"}}
</div>
{{end}}
{{if (.Issue.ShowRole.HasRole "Owner")}}
<div class="ui basic label role-label">
Copy link
Contributor

@wxiaoguang wxiaoguang Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were "role-label" classes, they are lost now?

Copy link
Contributor Author

@yp05327 yp05327 Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only in this place have role-label class, didn't understand the usage here, but I understand the usage of role-label now: hide them in mobiles.

In GitHub will not display role label in mobiles, so we can add this in the general template.
image
image

In Gitea:
image
After:
image

{{$.locale.Tr "repo.issues.owner"}}
</div>
{{end}}
{{end}}
{{template "repo/issue/view_content/show_role" dict "ShowRole" .Issue.ShowRole "locale" $.locale "IgnorePoster" true}}
{{if not $.Repository.IsArchived}}
{{template "repo/issue/view_content/add_reaction" dict "ctxData" $ "ActionURL" (printf "%s/issues/%d/reactions" $.RepoLink .Issue.Index)}}
{{template "repo/issue/view_content/context_menu" dict "ctxData" $ "item" .Issue "delete" false "issue" true "diff" false "IsCommentPoster" $.IsIssuePoster}}
Expand Down
56 changes: 7 additions & 49 deletions templates/repo/issue/view_content/comments.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,7 @@
{{end}}
</div>
<div class="comment-header-right actions gt-df gt-ac">
{{if (.ShowRole.HasRole "Poster")}}
<div class="ui basic label">
{{$.locale.Tr "repo.issues.poster"}}
</div>
{{end}}
{{if (.ShowRole.HasRole "Writer")}}
<div class="ui basic label">
{{$.locale.Tr "repo.issues.collaborator"}}
</div>
{{end}}
{{if (.ShowRole.HasRole "Owner")}}
<div class="ui basic label">
{{$.locale.Tr "repo.issues.owner"}}
</div>
{{end}}
{{template "repo/issue/view_content/show_role" dict "ShowRole" .ShowRole "locale" $.locale}}
{{if not $.Repository.IsArchived}}
{{template "repo/issue/view_content/add_reaction" dict "ctxData" $ "ActionURL" (printf "%s/comments/%d/reactions" $.RepoLink .ID)}}
{{template "repo/issue/view_content/context_menu" dict "ctxData" $ "item" . "delete" true "issue" true "diff" false "IsCommentPoster" (and $.IsSigned (eq $.SignedUserID .PosterID))}}
Expand Down Expand Up @@ -442,25 +428,11 @@
</span>
</div>
<div class="comment-header-right actions gt-df gt-ac">
{{if (.ShowRole.HasRole "Poster")}}
<div class="ui basic label">
{{$.locale.Tr "repo.issues.poster"}}
</div>
{{end}}
{{if (.ShowRole.HasRole "Writer")}}
<div class="ui basic label">
{{$.locale.Tr "repo.issues.collaborator"}}
</div>
{{end}}
{{if (.ShowRole.HasRole "Owner")}}
<div class="ui basic label">
{{$.locale.Tr "repo.issues.owner"}}
</div>
{{end}}
{{if not $.Repository.IsArchived}}
{{template "repo/issue/view_content/add_reaction" dict "ctxData" $ "ActionURL" (printf "%s/comments/%d/reactions" $.RepoLink .ID)}}
{{template "repo/issue/view_content/context_menu" dict "ctxData" $ "item" . "delete" false "issue" true "diff" false "IsCommentPoster" (and $.IsSigned (eq $.SignedUserID .PosterID))}}
{{end}}
{{template "repo/issue/view_content/show_role" dict "ShowRole" .ShowRole "locale" $.locale}}
{{if not $.Repository.IsArchived}}
{{template "repo/issue/view_content/add_reaction" dict "ctxData" $ "ActionURL" (printf "%s/comments/%d/reactions" $.RepoLink .ID)}}
{{template "repo/issue/view_content/context_menu" dict "ctxData" $ "item" . "delete" false "issue" true "diff" false "IsCommentPoster" (and $.IsSigned (eq $.SignedUserID .PosterID))}}
{{end}}
</div>
</div>
<div class="ui attached segment comment-body">
Expand Down Expand Up @@ -567,21 +539,7 @@
</span>
</div>
<div class="comment-header-right actions gt-df gt-ac">
{{if (.ShowRole.HasRole "Poster")}}
<div class="ui basic label">
{{$.locale.Tr "repo.issues.poster"}}
</div>
{{end}}
{{if (.ShowRole.HasRole "Writer")}}
<div class="ui basic label">
{{$.locale.Tr "repo.issues.collaborator"}}
</div>
{{end}}
{{if (.ShowRole.HasRole "Owner")}}
<div class="ui basic label">
{{$.locale.Tr "repo.issues.owner"}}
</div>
{{end}}
{{template "repo/issue/view_content/show_role" dict "ShowRole" .ShowRole "locale" $.locale}}
{{if not $.Repository.IsArchived}}
{{template "repo/issue/view_content/add_reaction" dict "ctxData" $ "ActionURL" (printf "%s/comments/%d/reactions" $.RepoLink .ID)}}
{{template "repo/issue/view_content/context_menu" dict "ctxData" $ "item" . "delete" true "issue" true "diff" true "IsCommentPoster" (and $.IsSigned (eq $.SignedUserID .PosterID))}}
Expand Down
15 changes: 15 additions & 0 deletions templates/repo/issue/view_content/show_role.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{{if and (.ShowRole.HasRole "Poster") (not .IgnorePoster)}}
<div class="ui basic label">
{{.locale.Tr "repo.issues.poster"}}
</div>
{{end}}
{{if (.ShowRole.HasRole "Writer")}}
<div class="ui basic label">
{{.locale.Tr "repo.issues.collaborator"}}
</div>
{{end}}
{{if (.ShowRole.HasRole "Owner")}}
<div class="ui basic label">
{{.locale.Tr "repo.issues.owner"}}
</div>
{{end}}