Handle missing README in create repos API (#23387)
#23509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close go-gitea#22934 In `/user/repos` API (and other APIs related to creating repos), user can specify a readme template for auto init. At present, if the specified template does not exist, a `500` will be returned . This PR improved the logic and will return a `400` instead of `500`.
lunny
approved these changes
Mar 16, 2023
GiteaBot
added
the
lgtm/need 1
silverwind
approved these changes
Mar 16, 2023
GiteaBot
added
lgtm/done
Member
|
This should have been 422 as this is validation error not bad request that would be for example for unparsable JSON or things like that |
Member
|
Hmm… I disagree. |
delvh
approved these changes
Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23387
Close #22934
In
/user/reposAPI (and other APIs related to creating repos), user can specify a readme template for auto init. At present, if the specified template does not exist, a500will be returned . This PR improved the logic and will return a400instead of500.