Skip to content

Warn on SSH connection for incorrect configuration #19317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techknowlogick merged 6 commits into from
Apr 5, 2022
Merged

Warn on SSH connection for incorrect configuration #19317

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
900f234
Warn on SSH connection for incorrect configuration
Apr 3, 2022
3306816
Update cmd/serv.go
techknowlogick Apr 5, 2022
2e47797
Don't leak configuration
Apr 5, 2022
b0b8d83
Merge branch 'main' into warn-incorrect-configuration
Apr 5, 2022
cfa9ba3
Update cmd/serv.go
wxiaoguang Apr 5, 2022
71d701a
Merge branch 'main' into warn-incorrect-configuration
techknowlogick Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cmd/serv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,15 @@ func runServ(c *cli.Context) error {
gitcmd = exec.CommandContext(ctx, verb, repoPath)
}

// Check if setting.RepoRootPath exists. It could be the case that it doesn't exist, this can happen when
// `[repository]` `ROOT` is a relative path and $GITEA_WORK_DIR isn't passed to the SSH connection.
if _, err := os.Stat(setting.RepoRootPath); err != nil {
if os.IsNotExist(err) {
return fail("Incorrect configuration.",
"Directory "`[repository]` `ROOT`" was not found, please check if $GITEA_WORK_DIR is passed to the SSH connection or make `[repository]` `ROOT` an absolute value.")
Comment thread
wxiaoguang marked this conversation as resolved.
Outdated
}
}

gitcmd.Dir = setting.RepoRootPath
gitcmd.Stdout = os.Stdout
gitcmd.Stdin = os.Stdin
Expand Down