Skip to content

Place inline diff comment dialogs on split diff in 4th and 8th columns (#18403) #18404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Place inline diff comment dialogs on split diff in 4th and 8th columns (#18403) #18404

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7d627e
Place inline diff comment dialogs on split diff in 4th and 8th columns
zeripath Jan 25, 2022
6c48785
Merge branch 'release/v1.16' into backport-18403
zeripath Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions web_src/js/features/repo-issue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,9 +496,11 @@ export function initRepoPullRequestReview() {
<tr class="add-comment" data-line-type="${lineType}">
${isSplit ? `
<td class="lines-num"></td>
<td class="lines-escape"></td>
<td class="lines-type-marker"></td>
<td class="add-comment-left"></td>
<td class="lines-num"></td>
<td class="lines-escape"></td>
<td class="lines-type-marker"></td>
<td class="add-comment-right"></td>
` : `
Expand Down