Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented May 10, 2021

The goth user stored in session is the struct but not the pointer to it.

Bug introduced in #5123

@lunny lunny added the type/bug label May 10, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 10, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2021
@zeripath zeripath merged commit 3656a2a into go-gitea:main May 10, 2021
@6543 6543 added the issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change label May 10, 2021
@6543 6543 added this to the 1.15.0 milestone May 10, 2021
@lunny lunny deleted the lunny/fix_goth_user-infer branch May 11, 2021 06:49
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 11, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants