Skip to content

Fix PR/Issue titles on mobile #13292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lafriks merged 5 commits into from
Oct 24, 2020
Merged

Fix PR/Issue titles on mobile #13292

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33c0f25
Start fixing Issue & PR title on mobile
kolaente Oct 24, 2020
a00fb84
Make sure the save & cancel buttons float right
kolaente Oct 24, 2020
f555387
Fix edit buttons and title input on mobile
kolaente Oct 24, 2020
c98c40f
Merge branch 'master' into fix/pr-title-mobile
lunny Oct 24, 2020
1d082a3
Merge branch 'master' into fix/pr-title-mobile
kolaente Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions templates/repo/issue/view_title.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,21 @@
<div class="sixteen wide column title">
<div class="ui grid">
<h1 class="twelve wide column">
<div class="issue-title" id="issue-title-wrapper">
{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}}
<div class="edit-button">
<div id="edit-title" class="ui basic green not-in-edit button">{{.i18n.Tr "repo.issues.edit"}}</div>
</div>
{{end}}
<h1>
<span class="index">#{{.Issue.Index}}</span> <span id="issue-title">{{RenderEmoji .Issue.Title}}</span>
<div id="edit-title-input" class="ui input" style="display: none">
<input value="{{.Issue.Title}}" maxlength="255">
</div>
</h1>
{{if and (or .HasIssuesOrPullsWritePermission .IsIssuePoster) (not .Repository.IsArchived)}}
<div class="four wide column">
<div class="edit-zone text right">
<div id="edit-title" class="ui basic green not-in-edit button">{{.i18n.Tr "repo.issues.edit"}}</div>
<div id="cancel-edit-title" class="ui basic blue in-edit button" style="display: none">{{.i18n.Tr "repo.issues.cancel"}}</div>
<div id="save-edit-title" class="ui green in-edit button" style="display: none" data-update-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/title" {{if .Issue.IsPull}}data-target-update-url="{{$.RepoLink}}/pull/{{.Issue.Index}}/target_branch"{{end}}>{{.i18n.Tr "repo.issues.save"}}</div>
</div>
</div>
<div class="edit-buttons">
<div id="cancel-edit-title" class="ui basic blue in-edit button" style="display: none">{{.i18n.Tr "repo.issues.cancel"}}</div>
<div id="save-edit-title" class="ui green in-edit button" style="display: none" data-update-url="{{$.RepoLink}}/issues/{{.Issue.Index}}/title" {{if .Issue.IsPull}}data-target-update-url="{{$.RepoLink}}/pull/{{.Issue.Index}}/target_branch"{{end}}>{{.i18n.Tr "repo.issues.save"}}</div>
</div>
{{end}}
</div>
{{if .HasMerged}}
Expand Down
1 change: 1 addition & 0 deletions web_src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,6 +792,7 @@ async function initRepository() {
$('#pull-desc').toggle();
$('#pull-desc-edit').toggle();
$('.in-edit').toggle();
$('#issue-title-wrapper').toggleClass('edit-active');
$editInput.focus();
return false;
};
Expand Down
96 changes: 73 additions & 23 deletions web_src/less/_repository.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,36 +632,86 @@
.title {
padding-bottom: 0 !important;

h1 {
font-weight: 300;
font-size: 2.3rem;
margin-bottom: 5px;
.issue-title {
margin-bottom: .5rem;

.ui.input {
font-size: .5em;
vertical-align: top;
width: 50%;
min-width: 600px;
&.edit-active {
display: flex;
align-items: center;

input {
font-size: 1.5em;
padding: 6px 10px;
h1 {
display: flex;
width: 100%;
}

@media only screen and (max-width: 768px) {
flex-direction: column;

h1 {
margin-right: 0;
margin-bottom: 1rem;
padding-right: 0;

.ui.input input {
width: calc(100% - 2rem);
}
}

.edit-buttons {
padding-bottom: 1rem;
width: 100%;

.button {
width: 100%;
margin-right: .5rem;

&:last-child {
margin-right: 0;
}
}
}
}
}
}

.index {
font-weight: 300;
color: #aaaaaa;
letter-spacing: -1px;
}
h1 {
font-weight: 300;
font-size: 2.3rem;
margin: 0;
padding-right: .5rem;

.label {
margin-right: 10px;
}
.ui.input {
font-size: .5em;
width: 100%;

.edit-zone {
margin-top: 10px;
input {
font-size: 1.5em;
padding: 6px 1rem;
}
}
}

.edit-button {
float: right;
padding-left: 1rem;
}

.edit-buttons {
display: flex;
}

.index {
font-weight: 300;
color: #aaaaaa;
letter-spacing: -1px;
}

.label {
margin-right: 10px;
}

.edit-zone {
margin-top: 10px;
}
}
}

Expand Down