Skip to content

[Vendor] Switch go-version lib #12719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
techknowlogick merged 16 commits into from
Sep 5, 2020
Merged

[Vendor] Switch go-version lib #12719

techknowlogick merged 16 commits into from
Sep 5, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Sep 4, 2020 •
edited
Loading

as title

6543
6543 commented Sep 4, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 4, 2020
6543
6543 commented Sep 4, 2020
View reviewed changes
zeripath
zeripath reviewed Sep 4, 2020
View reviewed changes
6543
6543 commented Sep 4, 2020
View reviewed changes
techknowlogick
techknowlogick reviewed Sep 4, 2020
View reviewed changes
@6543 6543 added dependencies type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Sep 4, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #12719 into master will decrease coverage by 0.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12719      +/-   ##
==========================================
- Coverage   43.40%   43.39%   -0.02%     
==========================================
  Files         647      647              
  Lines       71500    71523      +23     
==========================================
- Hits        31038    31034       -4     
- Misses      35443    35461      +18     
- Partials     5019     5028       +9
Impacted Files Coverage Δ
modules/git/repo_attribute.go 0.00% <0.00%> (ø)
modules/git/repo_tag.go 61.68% <ø> (-0.25%) ⬇️
modules/git/repo_tree.go 40.00% <0.00%> (ø)
routers/admin/admin.go 11.45% <0.00%> (-0.04%) ⬇️
routers/repo/lfs.go 0.00% <0.00%> (ø)
services/mirror/mirror.go 18.58% <0.00%> (ø)
modules/git/git.go 40.00% <50.00%> (+2.33%) ⬆️
modules/setting/setting.go 46.81% <50.00%> (ø)
services/pull/merge.go 50.14% <80.00%> (ø)
modules/git/command.go 88.34% <100.00%> (+1.94%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdb4f8...64a0634. Read the comment docs.

@6543 6543 added this to the 1.13.0 milestone Sep 5, 2020
@6543 6543 changed the title [WIP] [Vendor] Switch go-version lib [Vendor] Switch go-version lib Sep 5, 2020
techknowlogick
techknowlogick reviewed Sep 5, 2020
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2020
@techknowlogick techknowlogick merged commit bc11caf into go-gitea:master Sep 5, 2020
@6543 6543 deleted the vendor-switch-goversion-lib branch September 5, 2020 18:26
@6543 6543 mentioned this pull request Sep 5, 2020
Closed
2 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

5 participants

@6543 @codecov-commenter @techknowlogick @zeripath @GiteaBot