Skip to content

fix check it.Err() != nil but return a nil value error err #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix check it.Err() != nil but return a nil value error err #3886

merged 1 commit into from
Dec 19, 2024

Conversation

@alingse
Copy link
Contributor

@alingse alingse commented Dec 19, 2024

No description provided.

@aarzilli aarzilli mentioned this pull request Dec 19, 2024
Closed
aarzilli
aarzilli approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekparker
derekparker approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 1a55e8e into go-delve:master Dec 19, 2024
2 checks passed
@alingse alingse mentioned this pull request Dec 20, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarzilli aarzilli aarzilli approved these changes

@derekparker derekparker derekparker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alingse @aarzilli @derekparker