Skip to content

[bug 802] - Ability to undo or restore changes to the preferences #802#822

Merged
mattrose merged 2 commits intognome-terminator:masterfrom
vssdeo:802-Ability-to-undo-or-restore-changes-to-the-preferences
Feb 5, 2024
Merged

[bug 802] - Ability to undo or restore changes to the preferences #802#822
mattrose merged 2 commits intognome-terminator:masterfrom
vssdeo:802-Ability-to-undo-or-restore-changes-to-the-preferences

Conversation

@vssdeo
Copy link
Contributor

@vssdeo vssdeo commented Sep 4, 2023

Changes

  • added basic config restore option from preferences window
  • changes to glade made in addition to addition of destory signal
  • minor cleaup in config to have a single function return confilg filename via get_config_filename

Things to Cross Check

  • position of restore button in preference window
  • name of button
  • additional behavior like enabling button only on change or a simple standard way like current one is ok ?

…ome-terminator#802

 - added basic config restore option from preferences window
 - changes to glade made in addition to addition of destory signal
 - minor cleaup in config to have a single function return confilg filename via get_config_filename
…nome-terminator#802

- fixed the errors in case of missing configs
- restore file is stored in writable path
@mattrose
Copy link
Member

mattrose commented Feb 5, 2024

I like it! Thanks for your work and sorry about the wait

@mattrose mattrose merged commit b13d356 into gnome-terminator:master Feb 5, 2024
@waldyrious
Copy link

Thanks for implementing this, @vssdeo! For future reference, below is a screenshot showing what this looks like. It consists of a "Discard Changes" button at the bottom of the preferences screen:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants