Remove hack to ensure that focus is set.

[mattrose]

set_focus() should do the trick according to the docs, so let's just use that, and not go to extraordinary measures.

fixes #714 hopefully

[Vulcalien]

I lost focus on start after this. I'm on X11, Gnome, Debian 12. I'll try to fix it.

Removing the line window.set_focus(), it then works fine for me.

[mattrose]

Removing the line window.set_focus(), it then works fine for me.

Oo, can you send in a PR with that and I'll merge it?

If not, it's a simple change I can do if you want.

[mattrose]

Days like this I love GTK. This function does the exact opposite of what the function says it does. 😛

[Vulcalien]

I think the "restore focus" feature isn't working altogether.
That part of the code is meant to focus the last active terminal in a layout, right?

If that's so, then I believe that instead of focusing the last active window, we should focus the last window's last active terminal.

Edit: I think it wasn't working with the "awful workaround" code either.
And set_focus may be taking an argument. If it's None, it removes the focus.

[mattrose]

@Vulcalien do you have a config that can reproduce the problem, or is it now fixed with the final change?

[Vulcalien]

config.txt

Here there are two windows, each with one terminal.
From what I read in the config file, the terminal named "This terminal should be focused" should be.. well, focused. Instead, the focus goes to the unnamed window (at least in my machine).

---

config.txt

For some reason, having a notebook influences how the focus is chosen. In this case, it works as it should.
In other tests (config.txt), it doesn't.

---

What I think it's happening, is that the window that is written as last in the config file is the one that grabs the focus, every time.
I've tried looking for the cause, but found nothing.

Edit: very likely the behavior differs greatly between desktop environments. I'm on Gnome 43, X11.