Fix missing icons when started with Ctrl-Alt-T#628
Merged
mattrose merged 1 commit intognome-terminator:masterfrom Oct 30, 2022
Merged
Fix missing icons when started with Ctrl-Alt-T#628mattrose merged 1 commit intognome-terminator:masterfrom
mattrose merged 1 commit intognome-terminator:masterfrom
Conversation
By default, GTK sets the prgname to argv[0], which is then used to choose the correct .desktop file. If the program is run through a symlink, such as through `/etc/alternatives/x-terminal-emulator`, argv[0] is not `terminator` so under Wayland the desktop file is not detected, leading to a missing icon.
MihaiBabiac
changed the title
|
Tested on a fresh Ubuntu 22.04.1 install and works as expected. |
Member
|
Thanks for tracking this down! I've been trying to track down the cause for this for a while |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, GTK sets the prgname to argv[0], which is then used to choose the correct .desktop file. If the program is run through a symlink, such as through
/etc/alternatives/x-terminal-emulator, argv[0] is notterminatorso under Wayland the desktop file is not detected, leading to a missing icon.Possibly fixes these issues:
https://askubuntu.com/questions/1218884/terminator-does-not-add-to-dock-icon-when-opened-via-ctrlaltt
https://bugs.launchpad.net/terminator/+bug/1726525