hangs after update

[wellic]

Hi.
Could you help install the last version of the terminator?

The program hangs after updating from the master commit ebc266e5544d7b63196e155be24195a9f81c692e.
I used git bisect and found broken commit 77696aa2cdc95c356501a1ba971684ee1aee857b

$ git bisect bad
77696aa2cdc95c356501a1ba971684ee1aee857b is the first bad commit
commit 77696aa2cdc95c356501a1ba971684ee1aee857b
Author: Matt Rose <mattrose@folkwolf.net>
Date:   Fri Nov 13 10:05:12 2020 -0500

    fix issue #74

:040000 040000 ba6202b42c999369dd660cbea27effb053efe695 4f7ff2388e9b0cef91504fd91f1c9290da1ea07e M	terminatorlib

I reverted git revert -n 77696aa2cdc95c356501a1ba971684ee1aee857b , reinstall and all work ok.

OS: Ubuntu 18.04.5

[mattrose]

Hmm, can you run terminator -u -d and see if/when it hangs? I'll try and spin up an ubuntu18.04.5 environment for debugging this morning. Thanks for running master so we can catch these things earlier!

[mattrose]

Figured it out. I'm using a newer vte method that's not in the vte lib that comes with ubuntu 18.04 when rendering the terminal. I'll fix that up. Thanks for the report. Is it ok if I ask you to test out the PR to make sure it fixes it for you when I have it ready?

[mattrose]

#294 works on my ubuntu 18 vm, would you mind trying it out?

[wellic]

@mattrose I have issue.

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/terminatorlib/terminal.py", line 45, in do_draw
    bgc = Vte.Terminal.get_color_background_for_draw(self)
AttributeError: type object 'Terminal' has no attribute 'get_color_background_for_draw'

[wellic]

How to install a new vte?

[wellic]

Hmm, can you run terminator -u -d and see if/when it hangs? I'll try and spin up an ubuntu18.04.5 environment for debugging this morning. Thanks for running master so we can catch these things earlier!

I created small installer for me and try use last version terminator https://github.com/wellic/bash_tools/blob/master/bin/tools/terminator_install.sh

:)

[wellic]

#294 works on my ubuntu 18 vm, would you mind trying it out?

Pull request has status 'Merging is blocked'

[wellic]

@mattrose
I've applied you PR https://github.com/gnome-terminator/terminator/pull/294/ - all ok.