Conversation
70bf108 to
bfab711
Compare
AdaJane
commented
Feb 22, 2023
AdaJane
commented
Feb 22, 2023
AdaJane
commented
Feb 22, 2023
a4e1a86 to
75f5a0e
Compare
CAGS295
reviewed
Feb 23, 2023
nathanwhit
reviewed
Feb 23, 2023
Contributor
nathanwhit
left a comment
There was a problem hiding this comment.
Couple of small things, but aside from the remaining todos in the staking pallet LGTM
|
For full LLVM coverage report click here! |
atodorov
reviewed
Feb 24, 2023
c205215 to
335dbbf
Compare
atodorov
reviewed
Mar 9, 2023
dd04f64 to
ec53bc8
Compare
Codecov Report
@@ Coverage Diff @@
## dev #934 +/- ##
==========================================
+ Coverage 77.16% 77.62% +0.45%
==========================================
Files 74 75 +1
Lines 11427 11383 -44
==========================================
+ Hits 8818 8836 +18
+ Misses 2609 2547 -62
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
atodorov
requested changes
Mar 14, 2023
atodorov
approved these changes
Mar 14, 2023
atodorov
previously approved these changes
Mar 15, 2023
1e2fc93 to
b54a36e
Compare
atodorov
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes:
Updates Substrate from version on the
polkadot-v0.9.32branch to the latestpolkadot-v0.9.38branch allowing, introducing a few fixes and laying the groundwork to migrate to ParityDB.From polkadot-v0.9.32 to polkadot-v0.9.38
Polkadot-v0.9.33
No changes
Polkadot-v0.9.34
Change WEIGHT_PER_SECOND to WEIGHT_REF_TIME_PER_SECOND
Added a call to
from_ref_timePolkadot-v0.9.35
Update jsonrpsee version to 0.16.2 to match Susbtrate
Polkadot-v0.9.36
No Changes
Polkadot-v0.9.37
No Changes
Polkadot-v0.9.38
Add implementations for
query_weight_to_feeandquery_length_to_feetoimpl pallet_transaction_ayment_rpc_runtime_api::TransactionPaymentApi for RuntimeAdd explicit call indexes for pallet runtime APIs using script provided by Parity/Substrate:
More info here
Updated Staking Pallet impls to new API signatures
Practical tips for PR review & merge: