Skip to content

Fix strict mode #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2019
Merged

Fix strict mode #855

merged 1 commit into from
Mar 1, 2019

Conversation

@ashubham
Copy link
Contributor

@ashubham ashubham commented Feb 27, 2019 •
edited
Loading

Adding properties to strings is disallowed in strict mode. Fixes #854

@ashubham
Fix strict mode
df3faa8 
Adding properties to strings is disallowed in strict mode.
@jsf-clabot
Copy link

jsf-clabot commented Feb 27, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

rxaviers
rxaviers reviewed Feb 27, 2019
View reviewed changes
@rxaviers
Copy link
Member

rxaviers commented Feb 27, 2019

Thanks for your PR, I left some comments.

@ashubham
Copy link
Contributor Author

ashubham commented Feb 27, 2019

@rxaviers Thanks for taking a look. Responded.

@rxaviers rxaviers merged commit 04304b2 into globalizejs:master Mar 1, 2019
@rxaviers
Copy link
Member

rxaviers commented Mar 1, 2019

Thank you!

@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rxaviers rxaviers rxaviers left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashubham @jsf-clabot @rxaviers