Merged
Conversation
It was spinning on resign, if the 450th ply was a win/loss/draw it wasn't recognized, and if the 450th ply was a win/loss/draw it was trying to play a move from that position.
Contributor
Author
|
The bugs I'm aiming to fix here.
|
Collaborator
Contributor
Author
|
Yes if we want both self play and matches to use resign, both are useful. (I don't personally see the value in resign for matches... but its not my opinion alone that matters :P) |
Contributor
Author
|
Did some testing, including using the decode_training python script. Seems to be working fine? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting up this PR without any testing, to get early opinions.
I think its a pretty obvious improvement over the previous logic - but I'll need to double check its interaction with the client to be sure.