Skip to content

Rename public-facing code/variables from "visits" to "nodes"#512

Merged
killerducky merged 2 commits intoglinscott:nextfrom
dubslow:visits2nodes
May 4, 2018
Merged

Rename public-facing code/variables from "visits" to "nodes"#512
killerducky merged 2 commits intoglinscott:nextfrom
dubslow:visits2nodes

Conversation

@dubslow
Copy link
Contributor

@dubslow dubslow commented May 3, 2018

The --visits option is kept as hidden for compatibility. --visits and --nodes are equivalent.

This would remove some ambiguity in public facing engine-use documentation, including what "playouts" means.

Acceptance of this PR should be accompanied by simultaneous wiki updates to reflect the change.

The --visits option is kept as hidden for compatibilty. --visits and --nodes are equivalent.
@evalon32
Copy link
Contributor

evalon32 commented May 4, 2018

I worry a little about advertising equivalence between visits and nodes given that they are not really equivalent: a terminal node can be visited many times without additional expansion, resulting in visits > nodes and sometimes even visits >> nodes.

@dubslow
Copy link
Contributor Author

dubslow commented May 4, 2018

The wiki already has a big fat asterisk for this corner case. But the code doesn't change, and this is much more understandable I think. And besides the same thing can be said for playouts, and the difference between playouts and visits is far more confusing than the difference between nodes and visits. So not perfect, but still a significant improvement on the current situation I think.

@killerducky killerducky merged commit 7c797f6 into glinscott:next May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants