Rename public-facing code/variables from "visits" to "nodes"#512
Merged
killerducky merged 2 commits intoglinscott:nextfrom May 4, 2018
Merged
Rename public-facing code/variables from "visits" to "nodes"#512killerducky merged 2 commits intoglinscott:nextfrom
killerducky merged 2 commits intoglinscott:nextfrom
Conversation
The --visits option is kept as hidden for compatibilty. --visits and --nodes are equivalent.
Contributor
|
I worry a little about advertising equivalence between visits and nodes given that they are not really equivalent: a terminal node can be visited many times without additional expansion, resulting in visits > nodes and sometimes even visits >> nodes. |
Contributor
Author
|
The wiki already has a big fat asterisk for this corner case. But the code doesn't change, and this is much more understandable I think. And besides the same thing can be said for playouts, and the difference between playouts and visits is far more confusing than the difference between nodes and visits. So not perfect, but still a significant improvement on the current situation I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --visits option is kept as hidden for compatibility. --visits and --nodes are equivalent.
This would remove some ambiguity in public facing engine-use documentation, including what "playouts" means.
Acceptance of this PR should be accompanied by simultaneous wiki updates to reflect the change.