Add support for Consul unix sockets #336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for socket-based Consul connections. This would be especially convenient in overlay network environments where it could be difficult to tell whether you're talking to the local Consul node or a remote one. It'd also be useful in Docker-in-Docker use cases like RancherOS where you may want to run Registrator in
system-dockerso that it's available immediately on boot.I piggy-backed onto the existing
consulandconsulkvFactories by adding a-unixsuffix to the schemes and then doing a little additional parsing inNew().The service backend works as expected, but the KV backend looks a little funky. Since we can't rely on slashes for the path (and thus the KV prefix), there's an extra colon to delimit the prefix i.e.
consulkv-unix:///var/run/consul.sock:/base/key.Commits are squashed and docs are added, let me know what you think!