Open
Conversation
Collaborator
|
Sorry for slow response. I am not sure how I feel about this, it adds a lot of complexity and I think I prefer to not add any more logic to reading/printing the yaml files. |
Author
|
I understand the concern and of course I can just use my version of my branch, so feel free to close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
i18n-tasks normalizefeature, the ruby yaml library prefers to use single quotes. Those normalized files will then fail standard prettier checks. Prettier by default has a quotes strategy, where they minimize escapes and prefer double quotes. This PR makes the YAML quoting configurable, while keeping the current defaultsinglequotes.