Skip to content

🧪 add some claude-drafted tests for edge cases#3

Merged
gkumbhat merged 8 commits into
gkumbhat:separate_mm_encoder_schedulingfrom
joerunde:some-mm-edge-cases
Jul 2, 2026
Merged

🧪 add some claude-drafted tests for edge cases#3
gkumbhat merged 8 commits into
gkumbhat:separate_mm_encoder_schedulingfrom
joerunde:some-mm-edge-cases

Conversation

@joerunde

Copy link
Copy Markdown

WIP - adding claude assisted edge case tests in here

Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing.
Just a reminder: Make sure that your code passes all the linting checks, otherwise your PR won't be able to be merged. To do so, run ./format.sh.
Now you are good to go 🚀.

We also recommend installing prek and configuring it to check your code before every local commit.

joerunde added 5 commits June 30, 2026 17:13
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanna change the name of these files to be independent of PR ?

@joerunde joerunde marked this pull request as ready for review July 1, 2026 20:34
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>

@gkumbhat gkumbhat left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
@joerunde

joerunde commented Jul 1, 2026

Copy link
Copy Markdown
Author

@gkumbhat I'll let you merge this into your PR at your leisure (I don't have a merge button in your repo)

@gkumbhat gkumbhat left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gkumbhat gkumbhat merged commit 188e3fa into gkumbhat:separate_mm_encoder_scheduling Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants