Make line look like a capsule #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
added a commit
that referenced
this pull request
Nov 5, 2021
…terial (mrdoob#16912) * Add feature to LineMaterial to support toggling screen-space line width * Change lines parameter * remove magic number scaling * change if to use mix function * build jsm * rename variable to size attenuation, use defines * Add perspective attenuation with width in world units * Update comments * Add jsm build * revert statement position * Change sizeAttenuation to worldUnits * Fix endcaps not being perpendicular to line direction * Update js examples version * Make line look like a capsule (#6) * update js file * Update comments * Add a tighter containment for capsule * update module * small adjustment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.