Prevent qbank activities from being displayed after an activity move #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@jboulen This is just a patch, need evidential testing, what are the steps to replicate please? |
Collaborator
|
@jboulen Okay, thinking about it further given the logic of the core change, I'll take it from there. I won't be able to patch here as I have a development repository and use this purely for releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Moodle 5.0, there is a bug when moving an activity in a course that contains a question bank.
After moving, the new "qbank" module appears as activity in the course interface, when it shouldn't be.
We propose this fix, based on the changes made in the Moodle core (here and there).
I'm not sure, but maybe
is_of_type_that_can_display()should be used in this case too ?