Decyjphr/pr 683 #721
Merged
Decyjphr/pr 683 #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linting failed in deploymentConfig.js due to the static fields. Eslint supports this from ecmaVersion 13.
The full test suite failed because it tried to lint the tests, while the running linter did not do the same. Enabling linting gave errors due to jest having undef stuff, but overriding these files for jest env keeps the linting without these errors.
Removed to stop having eslint errors.
Updated with `npx standard --fix`. Skipping environments.js and environments.test.js as they had a lot of errors, handling those in a separate commit.
Updated with `npx standard --fix`.
This was done manually as no autofix was available.
Contributor
There was a problem hiding this comment.
Copilot reviewed 10 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .eslintrc.json: Language not supported
- test/unit/lib/plugins/environments.test.js: Evaluated as low risk
- test/unit/lib/plugins/labels.test.js: Evaluated as low risk
- test/unit/lib/env.test.js: Evaluated as low risk
- test/unit/index.test.js: Evaluated as low risk
Comments suppressed due to low confidence (2)
lib/plugins/environments.js:86
- The variable name existing_custom_branch_policies should be renamed to existingCustomBranchPolicies for consistency.
let existing_custom_branch_policies = existing.deployment_branch_policy === null ? null : existing.deployment_branch_policy.custom_branch_policies
lib/plugins/environments.js:90
- The variable name attrs_custom_branch_policies should be renamed to attrsCustomBranchPolicies for consistency.
let attrs_custom_branch_policies = attrs.deployment_branch_policy === null ? null : attrs.deployment_branch_policy.custom_branch_policies
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull and test #683
enterpriseis not handled as org level rulesets