Handle Actions Cancel Workflow Run returning a 202 #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the GitHub Actions cancel workflow run command incorrectly treats a 202 Accepted response as an error. The GitHub API returns a 202 status code on successful cancellation, but the go-github library wraps this as an AcceptedError which was being handled as a failure.
- Handle
github.AcceptedErroras a success case instead of an error - Add test coverage for both successful cancellation (202) and conflict scenarios (409)
- Update test assertion to use
Containsfor more flexible error message matching
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/github/actions.go | Add error type checking to handle AcceptedError as success |
| pkg/github/actions_test.go | Add comprehensive test cases and improve mock response handling |
almaleksia
previously approved these changes
Aug 11, 2025
JoannaaKL
approved these changes
Aug 12, 2025
nickytonline
pushed a commit
to nickytonline/github-mcp-http
that referenced
this pull request
Oct 4, 2025
Actions Cancel Workflow Run returns a 202 on success. Check for a `*github.AcceptedError` in response to the API call to handle this correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actions Cancel Workflow Run returns a 202 on success, but this is returned as an error in
google/go-github. We need to check if the error is a*github.AcceptedError, and only if not respond that this failed.