Skip to content

[Copilot Dreaming] Avoid invalid tool workflows and remove stale or duplicate guidance - #3894

Open
Copilot wants to merge 31 commits into
mainfrom
copilot/dream-curate-memories-20261119054900
Open

Copilot wants to merge 31 commits into
mainfrom
copilot/dream-curate-memories-20261119054900

Conversation

@Copilot

Copilot AI commented Nov 19, 2026

Copy link
Copy Markdown

🧠 How this helps Copilot

Tool migrations can otherwise return an unregistrable value, copy an incompatible schema default, or regenerate snapshots for ordering alone. Following the current constructor and schema contracts avoids those misleading migration steps.

Development guidance can send Copilot to a missing package, an incorrect workflow trigger or toolchain, an unsupported test-package convention, or a bare invocation that does not start the server. Stale size estimates can also narrow exploration prematurely. Correcting those directions and removing duplicate quality, validation, and package-priority mandates reduces independently maintained guidance for readers who already receive the complete duties.

Exploration can promise unsupported tree projections or repeat an upstream truncated fetch as if local filtering would recover missing entries. Removing those directions preserves the warnings about partial results without promising an ineffective recovery.

An empty automated-review response can be mistaken for completed review findings, and issue triage can assume semantic matching on hosts that use lexical search. Distinguishing those contracts avoids unsupported review conclusions and search expectations.

Project planning can follow a cursor the server does not emit, overlook supported view updates, or use an issue-field argument for a project option. Using the implemented project inputs and outputs avoids those invalid steps. Workflow diagnosis can also blame a skipped setup stage; selecting failed steps instead keeps localization and cross-attempt comparison focused on the failure.

Review commit by commit for each change's rationale and evidence.

Note

Copilot Dreaming curates this repository's Copilot instructions and skills in the background, proposing updates to help agents work here. Learn more about Copilot Dreaming.

Automated details

Source: curate-memories Dream, analyzing main at df32d7e.

Discarded guidance: The personal-token entry stays unchanged: removing its supported authentication path was rejected in review. Hosted merge-policy wording also stays unchanged because workflow event filters do not establish merge requirements.

copilot-dreamer[bot] added 30 commits November 19, 2026 05:48
The prescribed tuple cannot enter the server-tool registry. Matching the constructor's wrapper type avoids a migration that cannot be registered.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/dependencies.go#L229-L242
A bare tool literal is only one component of the constructor's server-tool wrapper. Keeping the example as a component avoids copying an incompatible return value.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/dependabot.go#L21-L49
A plain Go string does not match the schema default's JSON-byte representation. Using the established representation preserves the intended open default without a type mismatch.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/dependabot.go#L113-L117
Argument ordering is not a reason to regenerate these snapshots because their comparator ignores array order. Intentional-change confirmation and logical schema equivalence remain required in this guide.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/internal/toolsnaps/toolsnaps.go#L47-L66
The fixed file total understates the tracked Go inventory and risks narrowing exploration prematurely. Package navigation remains available without another aging size estimate.
The named toolsets package is absent from the checkout. The inventory builder owns this configuration, so the layout should lead contributors there rather than to a dead path.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/inventory/builder.go#L21-L64
A blanket push-and-pull-request description risks sending contributors looking for jobs that are selected only by release tags. The separate merge-policy sentence remains unchanged.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/workflows/goreleaser.yml#L1-L5
Following a moving stable toolchain does not reproduce the lint workflow's manifest-selected Go version. The owning configuration supplies both the action and executable pins.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/workflows/lint.yml#L19-L26
Release investigation should follow version-tag pushes rather than main-branch pushes. The prohibition on running the release script or pushing tags remains in Important Reminders.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/workflows/goreleaser.yml#L1-L5
The categorical internal-package description can prompt unnecessary rewrites of existing external tests. Keeping both package forms described avoids that misleading convention.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/dependencies_test.go#L1-L1
The same reader already receives the wide-audience clarity duty under Code Quality Standards. A second standalone mandate adds another copy to maintain; that duty remains at its original owner.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L18-L18
Code Quality Standards already requires maintaining or improving structure and forbids degradation. Repeating that duty adds upkeep without changing the contributor's action.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L20-L20
The same reader already receives the stronger necessary-comments rule under Code Quality Standards. Its self-documenting-code duty remains there without another standalone copy.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L21-L21
Library Usage already requires exports for potential external callers and protects existing export patterns. Maintaining a second narrower copy adds no contributor action; the complete duty remains in the overview.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L14-L14
The alternative toolsets package is absent from the checkout. Tool registration remains required at the existing constructor inventory rather than through an unavailable package.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/inventory.go#L13-L17
The root command has no server handler, so omitting the subcommand does not start the advertised transport. Explicit stdio invocation avoids that startup mistake without changing the Docker image's separate default.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/cmd/github-mcp-server/main.go#L30-L42
The same reader already receives the local stdio priority in Primary Package. Its scope remains there without a second standalone reminder to maintain.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L10-L10
The required command sequence already mandates the exact lint script before finishing or committing. That broader duty remains in Critical Build & Validation Steps without another narrower reminder.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L25-L31
The tool-change procedure already requires snapshot generation and committing intentional schema changes. Those duties remain at that task's owner without a separate reminder to keep synchronized.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L35-L40
The required command sequence already covers documentation generation for tools and toolsets. That complete condition remains there without a narrower standalone reminder.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L25-L31
The End-to-End Tests section already gives the token prerequisite, practical limitation and invocation. Keeping that complete recipe avoids another standalone prerequisite copy for the same reader.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L147-L156
Secondary Package already gives mcpcurl its lower priority and do-not-break duty. Those constraints remain in the overview without a second standalone copy.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/copilot-instructions.md#L11-L11
The repository-tree schema has no fields input. Restricting this response-size advice to searches avoids promising a tree projection that the tool does not implement.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/git.go#L54-L80
The path prefix is applied after the upstream tree fetch, so changing it cannot recover entries omitted by truncation. The warning against treating a partial tree as complete and the duty to report partial coverage remain here.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/git.go#L123-L168
…completion

A successful empty response requests a review rather than reporting its findings. Distinguishing those outcomes avoids an unsupported clean-review claim while retaining the not-an-approval and outstanding-human-review warnings.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/copilot.go#L971-L999
A portable triage reader cannot rely on semantic matching on GHES, where the constructor selects lexical search. Naming that distinction avoids promising meaning-based results to that audience.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/issues.go#L1962-L1977
Following endCursor cannot advance a response that emits nextCursor. Using the emitted cursor avoids repeating a page or reporting an incomplete board as complete.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/pkg/github/params.go#L461-L474
Conditionally skipped setup can precede the actual failure, so the first nonsuccessful step need not be the failing one. Keeping the failure-localization and log-evidence duties avoids misattributing that skipped stage.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/workflows/code-scanning.yml#L69-L92
Across attempts, a skipped conditional stage is not evidence of the failure's location. Comparing failed conclusions preserves the diagnostic comparison without classifying skipped setup as a code failure.

https://github.com/github/github-mcp-server/blob/df32d7ec5786e0e71932767fce9982409cbaec40/.github/workflows/code-scanning.yml#L69-L92
@Copilot
Copilot AI requested a review from a team as a code owner November 19, 2026 05:49
Copilot AI adaptive review requested due to automatic review settings November 19, 2026 05:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for this documentation-only update to Copilot instructions and bundled skills.

No open issues 🎉

What changed in this PR

This documentation-only PR aligns Copilot’s development instructions and bundled skills with the GitHub MCP Server’s current tool contracts, removing stale and duplicate guidance.

Changes:

  • Corrects tool-migration examples and repository development instructions.
  • Updates project-planning inputs, pagination, and host-specific issue-search guidance.
  • Clarifies truncated exploration results, asynchronous review requests, and failed-step diagnosis.
File Description
pkg/​skills/​catalog/​skills/​workflow-failure-triage/​SKILL.md Directs diagnosis to the first failed step rather than any non-successful step.
pkg/​skills/​catalog/​skills/​workflow-failure-triage/​references/​failure-classes.md Aligns cross-attempt comparisons with failed-step conclusions.
pkg/​skills/​catalog/​skills/​project-planning/​SKILL.md Corrects pagination cursors, view updates, and project-field arguments.
pkg/​skills/​catalog/​skills/​issue-backlog-triage/​SKILL.md Distinguishes lexical search on GHES from semantic search on other hosts.
pkg/​skills/​catalog/​skills/​copilot-task-delegation/​SKILL.md Distinguishes review requests from completed reviews.
pkg/​skills/​catalog/​skills/​codebase-exploration/​SKILL.md Removes unsupported tree projection and truncation-recovery guidance.
.github/​copilot-instructions.md Corrects repository, workflow, testing, and startup guidance; removes duplication.
.github/​agents/​go-sdk-tool-migrator.md Updates constructor and schema examples and removes ordering-only snapshot guidance.

Review effort: Balanced (adaptive)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants