Fix the entitlements team cache when there are multiple instances of GitHub in use. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The acceptance tests are also failing on main in the same way, so I don't think they're related to the change. |
jasonmacgowan
requested changes
Jan 29, 2024
Contributor
|
#32 should fix the acceptance test errors |
Contributor
|
@chrisgavin can you also bump the version so we can publish the gem when it merges 🙇 |
Co-authored-by: Jason Macgowan <[email protected]>
jasonmacgowan
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think currently the team cache gets confused when you have multiple GitHub Enterprise Server instances (or one Enterprise instance and DotCom) that have an organization and team with the same name.
To avoid this, I believe we need to include the base address of the instance as part of the cache structure. This ensures each instance has its own cache.