Skip to content

Conversation

@jmeridth
Copy link
Member

@jmeridth jmeridth commented May 21, 2024

Pull Request

Proposed Changes

  • add pull_request_target to release GitHub Action so we have access to fork PR labels

I am not worried about the security implications with us checking out the forked pull requests code. This action only fires after a merge to main so this means the pull request code has been reviewed by a maintainer. We are post-CI/code run.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, maintenance or breaking

- [x] add pull_request_target to release GitHub Action so we have access to fork PR labels

I am not worried about the security implications with us checking out the forked pull requests code. This action only fires after a merge to main so this means the pull request code has been reviewed by a maintainer. We are post-CI/code run.

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth self-assigned this May 21, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner May 21, 2024 15:50
@jmeridth jmeridth merged commit 1555dc2 into main May 21, 2024
@jmeridth jmeridth deleted the jm_add_pull_request_target_to_release_action branch May 21, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants