Go: Support for MaD barriers and barrier guards. #21015
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| pragma[noinline] | ||
| private predicate guards(Node g, ControlFlow::ConditionGuardNode guard, Node nd, SsaWithFields ap) { | ||
| guards(g, guard, nd) and nd = ap.getAUse() | ||
| private predicate guards( |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
aschackmull
force-pushed
the
go/mad-barriers
branch
2 times, most recently
from
70bdb01 to
66ec419
Compare
aschackmull
force-pushed
the
go/mad-barriers
branch
from
66ec419 to
10a0530
Compare
owen-mc
force-pushed
the
go/mad-barriers
branch
from
10a0530 to
0539b18
Compare
|
Now that #21011 is merged I've rebased this and added commits to convert all the easily-convertible barriers and barrier guards to MaD. After running DCA I think this could be merged (without a change note). |
owen-mc
force-pushed
the
go/mad-barriers
branch
from
0539b18 to
82e1eb4
Compare
|
@aschackmull I rebased this and added some commits converting the go barriers to MaD. I think this is ready to review, but I'll leave it to you to press the button. |
owen-mc
force-pushed
the
go/mad-barriers
branch
from
82e1eb4 to
d9d12cf
Compare
owen-mc
force-pushed
the
go/mad-barriers
branch
from
d9d12cf to
8602c4c
Compare
|
@aschackmull I've updated this to remove query-specific MaD sanitizers and implement them for all the sink kinds that go currently uses. This means some existing sanitizers aren't converted, but that's okay. I consider this ready for review and DCA. Note that I don't think the validation of sanitizer kinds is working, as when I was using query ids there weren't any test failures. |
2 participants
No description provided.