Skip to content

Change v3 deprecation message to warning. #3303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 17, 2025
Merged

Change v3 deprecation message to warning. #3303

merged 3 commits into from
Nov 17, 2025

Conversation

@mario-campos
Copy link
Contributor

@mario-campos mario-campos commented Nov 17, 2025

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Advanced setup - Impacts users who have custom workflows.
  • Default setup - Impacts users who use default setup.
  • GHES - Impacts GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@github-actions github-actions bot added the size/XS Should be very easy to review label Nov 17, 2025
@mario-campos mario-campos marked this pull request as ready for review November 17, 2025 15:24
@mario-campos mario-campos requested a review from a team as a code owner November 17, 2025 15:24
Copilot AI review requested due to automatic review settings November 17, 2025 15:24
Copilot finished reviewing on behalf of mario-campos November 17, 2025 15:25
Copilot AI reviewed Nov 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the severity of the CodeQL Action v3 deprecation notice from an error to a warning. The deprecation is scheduled for December 2026, and the message is intended to warn users in advance rather than indicate an immediate failure.

Key Changes:

  • Changed core.error() to core.warning() for the v3 deprecation message
  • Updated the corresponding test to spy on core.warning instead of core.error
  • Added a changelog entry explaining the change

Reviewed Changes

Copilot reviewed 10 out of 16 changed files in this pull request and generated 43 comments.

Show a summary per file
File Description
src/util.ts Changed deprecation message from error to warning level
src/util.test.ts Updated test spy to monitor core.warning instead of core.error
CHANGELOG.md Added entry documenting the severity downgrade
package-lock.json Unrelated peer dependency changes (automatically generated)
lib/*.js Generated JavaScript files reflecting the TypeScript changes

lib/setup-codeql-action.js
return error4 instanceof ConfigurationError ? "user-error" : "failure";
function getActionsStatus(error3, otherFailureCause) {
if (error3 || otherFailureCause) {
return error3 instanceof ConfigurationError ? "user-error" : "failure";
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expression will be implicitly converted from undefined to object.

Copilot uses AI. Check for mistakes.
lib/init-action.js
const flatResponse = (0, utils_js_1.flattenResponse)(rawResponse, operationSpec.responses[error4.statusCode] || operationSpec.responses["default"]);
error4.details = flatResponse;
} catch (error3) {
if (typeof error3 === "object" && (error3 === null || error3 === void 0 ? void 0 : error3.response)) {
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guard always evaluates to false.

Copilot uses AI. Check for mistakes.
lib/resolve-environment-action.js
const flatResponse = (0, utils_js_1.flattenResponse)(rawResponse, operationSpec.responses[error4.statusCode] || operationSpec.responses["default"]);
error4.details = flatResponse;
} catch (error3) {
if (typeof error3 === "object" && (error3 === null || error3 === void 0 ? void 0 : error3.response)) {
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guard always evaluates to false.

Copilot uses AI. Check for mistakes.
lib/autobuild-action.js
const flatResponse = (0, utils_js_1.flattenResponse)(rawResponse, operationSpec.responses[error4.statusCode] || operationSpec.responses["default"]);
error4.details = flatResponse;
} catch (error3) {
if (typeof error3 === "object" && (error3 === null || error3 === void 0 ? void 0 : error3.response)) {
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guard always evaluates to false.

Copilot uses AI. Check for mistakes.
lib/autobuild-action.js
}
}
if ((error4 === null || error4 === void 0 ? void 0 : error4.code) === "PARSE_ERROR" && (error4 === null || error4 === void 0 ? void 0 : error4.message.startsWith(`Error "Error: Unclosed root tag`))) {
if ((error3 === null || error3 === void 0 ? void 0 : error3.code) === "PARSE_ERROR" && (error3 === null || error3 === void 0 ? void 0 : error3.message.startsWith(`Error "Error: Unclosed root tag`))) {
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guard always evaluates to false.

Copilot uses AI. Check for mistakes.
lib/start-proxy-action.js
logger.info(`RetryPolicy: Network error ${retriableError} found, will retry.`);
return true;
}
}
if ((error4 === null || error4 === void 0 ? void 0 : error4.code) === "PARSE_ERROR" && (error4 === null || error4 === void 0 ? void 0 : error4.message.startsWith(`Error "Error: Unclosed root tag`))) {
if ((error3 === null || error3 === void 0 ? void 0 : error3.code) === "PARSE_ERROR" && (error3 === null || error3 === void 0 ? void 0 : error3.message.startsWith(`Error "Error: Unclosed root tag`))) {
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guard always evaluates to false.

Copilot uses AI. Check for mistakes.
lib/start-proxy-action.js
logger.info(`RetryPolicy: Network error ${retriableError} found, will retry.`);
return true;
}
}
if ((error4 === null || error4 === void 0 ? void 0 : error4.code) === "PARSE_ERROR" && (error4 === null || error4 === void 0 ? void 0 : error4.message.startsWith(`Error "Error: Unclosed root tag`))) {
if ((error3 === null || error3 === void 0 ? void 0 : error3.code) === "PARSE_ERROR" && (error3 === null || error3 === void 0 ? void 0 : error3.message.startsWith(`Error "Error: Unclosed root tag`))) {
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guard always evaluates to false.

Copilot uses AI. Check for mistakes.
lib/start-proxy-action.js
logger.info(`RetryPolicy: Network error ${retriableError} found, will retry.`);
return true;
}
}
if ((error4 === null || error4 === void 0 ? void 0 : error4.code) === "PARSE_ERROR" && (error4 === null || error4 === void 0 ? void 0 : error4.message.startsWith(`Error "Error: Unclosed root tag`))) {
if ((error3 === null || error3 === void 0 ? void 0 : error3.code) === "PARSE_ERROR" && (error3 === null || error3 === void 0 ? void 0 : error3.message.startsWith(`Error "Error: Unclosed root tag`))) {
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guard always evaluates to false.

Copilot uses AI. Check for mistakes.
lib/start-proxy-action.js
@@ -48838,24 +48838,24 @@ var require_dist_node15 = __commonJS({
});
module2.exports = __toCommonJS2(dist_src_exports);
var import_core = require_dist_node11();
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable import_core.

Copilot uses AI. Check for mistakes.
lib/setup-codeql-action.js
if (error4 || otherFailureCause) {
return error4 instanceof ConfigurationError ? "user-error" : "failure";
function getActionsStatus(error3, otherFailureCause) {
if (error3 || otherFailureCause) {
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expression always evaluates to false.

Copilot uses AI. Check for mistakes.
@mario-campos
Copy link
Contributor Author

mario-campos commented Nov 17, 2025

The failing check is because of this:

CSC : error CS1504: Source file '/Users/runner/work/codeql-action/codeql-action/obj/Debug/netcoreapp3.1/csharp.AssemblyInfo.cs' could not be opened -- Method not found: 'Boolean Microsoft.CodeAnalysis.EncodingExtensions.TryGetMaxCharCount(System.Text.Encoding, Int64, Int32 ByRef)'. [/Users/runner/work/codeql-action/codeql-action/csharp.csproj]

Not sure how that could be related to this PR, though... 🤔

mbg
mbg reviewed Nov 17, 2025
View reviewed changes
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if the tests pass. I restarted the one check that failed. Looks like it could be an intermittent problem.

I would remove the entry in the changelog for this though.

You also removed some options from the PR template that apply here. Let's talk about that elsewhere.

@mbg
Copy link
Member

mbg commented Nov 17, 2025

Yep, re-running the failed workflow worked. Not sure what went wrong and it's clearly intermittent, but as you observed, not related to this change.

@mario-campos mario-campos merged commit 07eae64 into main Nov 17, 2025
241 checks passed
@mario-campos mario-campos deleted the mario-campos/v3-core-warning branch November 17, 2025 17:35
This was referenced Nov 18, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mbg mbg mbg approved these changes

Assignees

No one assigned

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mario-campos @mbg