Skip to content

Add Ruby and Swift language autodetect test #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 11 commits into from
Nov 22, 2022
Merged

Add Ruby and Swift language autodetect test #1369

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
80d68ec
Add Swift language autodetect test
angelapwen Nov 15, 2022
f70f3fd
Merge branch 'main' into swift-autodetect
angelapwen Nov 15, 2022
23c7750
Merge branch 'main' into swift-autodetect
angelapwen Nov 15, 2022
b415ca9
Merge branch 'main' into swift-autodetect
angelapwen Nov 16, 2022
dfe79c8
Update generated check
angelapwen Nov 16, 2022
11436f9
Remove `TEST_MODE` environment variable
angelapwen Nov 17, 2022
7e70811
Update autogenerated checks
angelapwen Nov 17, 2022
87cd70c
Update multi language autodetect check
angelapwen Nov 17, 2022
541382a
Remove Swift-specific autodetect check
angelapwen Nov 17, 2022
c48901b
Remove Ruby autodetect check
angelapwen Nov 18, 2022
93b9fee
Remove if condition for non-Ruby/Swift languages
angelapwen Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions .github/workflows/__swift-autodetect.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions pr-checks/checks/swift-autodetect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# This check should be combined into `multi-language-autodetect.yml` once Swift is GA'ed
# and the `CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT` environment variable is not needed.
Copy link
Contributor

@henrymercer henrymercer Nov 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be fine to set CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT=true in multi-language-autodetect.yml to help cut down on the number of jobs. We could add some checks on the tools version to make sure that language autodetection does the right thing for old CLIs too.

name: "Swift analysis with language autodetection"
description: "Tests creation of a Swift database when language is not specified in `init`"
versions: ["latest", "cached", "nightly-latest"]
# Swift autobuilder is only supported on MacOS for private beta
operatingSystems: ["macos"]
env:
CODEQL_ENABLE_EXPERIMENTAL_FEATURES_SWIFT: "true"
steps:
- uses: ./../action/init
with:
tools: ${{ steps.prepare-test.outputs.tools-url }}
env:
TEST_MODE: true
- uses: ./../action/autobuild
- uses: ./../action/analyze
id: analysis
env:
TEST_MODE: true
- name: Check database
shell: bash
run: |
SWIFT_DB="${{ fromJson(steps.analysis.outputs.db-locations).swift }}"
if [[ ! -d "$SWIFT_DB" ]]; then
echo "Did not create a database for Swift."
exit 1
fi