Skip to content

Deprecate Go extraction reconciliation feature flag and CODEQL_EXTRACTOR_GO_BUILD_TRACING for custom builds #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 36 commits into from
Nov 14, 2022
+178 −610
Merged

Deprecate Go extraction reconciliation feature flag and CODEQL_EXTRACTOR_GO_BUILD_TRACING for custom builds #1322

Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
8b8dc7d
Remove `CODEQL_EXTRACTOR_GO_BUILD_TRACING` logic
angelapwen Oct 25, 2022
5503535
Remove `CODEQL_EXTRACTOR_GO_BUILD_TRACING` from test
angelapwen Oct 25, 2022
5864470
Remove unused `CODEQL_ACTION_RECONCILE_GO_EXTRACTION` from tests
angelapwen Oct 25, 2022
74baea2
Remove unused imports
angelapwen Oct 25, 2022
c7793db
Remove Go extraction reconciliation feature flag
angelapwen Nov 4, 2022
3becc76
Update src/languages.ts
angelapwen Nov 4, 2022
7df2d6d
Auto-generated files
angelapwen Nov 4, 2022
16cf4ce
Remove reconciliation from PR checks
angelapwen Nov 4, 2022
c209bf4
Remove redundant PR checks
angelapwen Nov 4, 2022
7dad98d
Add CHANGELOG entry
angelapwen Nov 4, 2022
ac4d339
PR check fixups
angelapwen Nov 4, 2022
949e561
Set `CODEQL_EXTRACTOR_GO_BUILD_TRACING` on again
angelapwen Nov 7, 2022
71369ba
Update CHANGELOG.md
angelapwen Nov 7, 2022
e6882da
Set `CODEQL_EXTRACTOR_GO_BUILD_TRACING` in `init`
angelapwen Nov 7, 2022
a08403b
Reconcile ubuntu version on PR checks
angelapwen Nov 7, 2022
5f635b1
Log Go env variable warning in `init`
angelapwen Nov 7, 2022
8ff4cc6
Test not setting `CODEQL_EXTRACTOR_GO_BUILD_TRACING`
angelapwen Nov 7, 2022
3dad0df
Add go setup action to debug artifact checks
angelapwen Nov 7, 2022
330c7a5
Update CHANGELOG.md
angelapwen Nov 8, 2022
b9539b0
Update user-facing warning log
angelapwen Nov 8, 2022
f16a98a
Apply suggestions from code review
angelapwen Nov 9, 2022
e85af3a
Add `GO111MODULE` to relevant PR checks
angelapwen Nov 10, 2022
d2f02e1
Add Go to multilanguage custom build test
angelapwen Nov 10, 2022
032b9ae
Stop setting `CODEQL_EXTRACTOR_GO_BUILD_TRACING` by default
angelapwen Nov 11, 2022
a1eaa44
Only display message in analyze
angelapwen Nov 11, 2022
1fa94b4
Remove mention of env variable in CHANGELOG
angelapwen Nov 11, 2022
f822e95
Fix linter issue
angelapwen Nov 14, 2022
10ffbfa
Merge branch 'main' into angelapwen/deprecate-go-env-var
angelapwen Nov 14, 2022
2c86f42
Merge remote-tracking branch 'origin/main' into angelapwen/deprecate-…
angelapwen Nov 14, 2022
a16ddd6
Merge remote-tracking branch 'origin/main' into angelapwen/deprecate-…
angelapwen Nov 14, 2022
b298af0
Merge branch 'angelapwen/deprecate-go-env-var' of github.com:github/c…
angelapwen Nov 14, 2022
dd2fdf4
Add setup Go step to unset env var check
angelapwen Nov 14, 2022
16597c3
Update CHANGELOG.md
angelapwen Nov 14, 2022
0d9e1b6
Change log levels to debug
angelapwen Nov 14, 2022
455bbb1
Merge branch 'angelapwen/deprecate-go-env-var' of github.com:github/c…
angelapwen Nov 14, 2022
5ee9bf8
Add PR link to CHANGELOG
angelapwen Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 0 additions & 92 deletions .github/workflows/__go-custom-tracing.yml
View file
Open in desktop

This file was deleted.

86 changes: 0 additions & 86 deletions .github/workflows/__go-reconciled-tracing-legacy-workflow.yml
View file
Open in desktop

This file was deleted.

7 changes: 3 additions & 4 deletions ...s/__go-reconciled-tracing-autobuilder.yml → ...ub/workflows/__go-tracing-autobuilder.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 3 additions & 17 deletions ...reconciled-tracing-custom-build-steps.yml → ...flows/__go-tracing-custom-build-steps.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions ...rkflows/__go-custom-tracing-autobuild.yml → ...orkflows/__go-tracing-legacy-workflow.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .github/workflows/debug-artifacts-failure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ jobs:
uses: ./.github/prepare-test
with:
version: latest
- uses: actions/setup-go@v3
with:
go-version: ^1.13.1
- uses: ./../action/init
with:
tools: ${{ steps.prepare-test.outputs.tools-url }}
Expand Down Expand Up @@ -87,4 +90,5 @@ jobs:
popd
done
env:
GO111MODULE: auto
INTERNAL_CODEQL_ACTION_DEBUG_LOC: true
4 changes: 4 additions & 0 deletions .github/workflows/debug-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ jobs:
uses: ./.github/prepare-test
with:
version: ${{ matrix.version }}
- uses: actions/setup-go@v3
with:
go-version: ^1.13.1
- uses: ./../action/init
with:
tools: ${{ steps.prepare-test.outputs.tools-url }}
Expand Down Expand Up @@ -113,4 +116,5 @@ jobs:
done
done
env:
GO111MODULE: auto
INTERNAL_CODEQL_ACTION_DEBUG_LOC: true
3 changes: 3 additions & 0 deletions .github/workflows/unset-environment-new-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ jobs:
uses: ./.github/prepare-test
with:
version: ${{ matrix.version }}
- uses: actions/setup-go@v3
with:
go-version: ^1.13.1
- uses: ./../action/init
with:
db-location: ${{ runner.temp }}/customDbLocation
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/unset-environment-old-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ jobs:
uses: ./.github/prepare-test
with:
version: ${{ matrix.version }}
- uses: actions/setup-go@v3
with:
go-version: ^1.13.1
- uses: ./../action/init
with:
languages: csharp,cpp,go,javascript,python
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## [UNRELEASED]

- Go is now analyzed in the same way as other compiled languages such as C/C++, C#, and Java. This completes the rollout of the feature described in [CodeQL Action version 2.1.27](#2127---06-oct-2022).
- Update the ML-powered additional query pack for JavaScript to version 0.4.0.
- Go is now analyzed in the same way as other compiled languages such as C/C++, C#, and Java. This completes the rollout of the feature described in [CodeQL Action version 2.1.27](#2127---06-oct-2022). As a result, the `CODEQL_EXTRACTOR_GO_BUILD_TRACING` environment variable, which was previously used to manually enable this behavior, is now deprecated. If your code scanning workflow uses this environment variable, we recommend that you remove it. Otherwise, you do not need to alter your code scanning workflows.
No user facing changes.

## 2.1.32 - 14 Nov 2022
Expand Down
Loading