Skip to content

Fix repository url parser in LicenseSuggestion #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

Fix repository url parser in LicenseSuggestion #1279

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be8022a
fix repository name parser in LicenseSuggestion
Cycloctane Apr 15, 2025
1abac18
Merge branch 'gh-pages' into fix_license_suggestion
mlinksva Apr 15, 2025
7162120
Update assets/js/app.coffee
Cycloctane Apr 15, 2025
fee0d8e
ignore query and fragment in repository url regex
Cycloctane Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions assets/js/app.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,14 +112,9 @@ class LicenseSuggestion

# Try to extract the repository full name from the user input
parseUserInput: (userInput) ->
repository = /https?:\/\/github\.com\/(.*?)\/(.+)(\.git)?$/.exec userInput
repository = /https?:\/\/github\.com\/([^\/]+)\/([^\/\?#]+)/.exec userInput
[_, username, project] = repository
project = project
.split /\/|\.git/
.filter (str) -> str
.slice 0, 1
.join ""
return username + '/' + project
return username + '/' + project.replace /(\.git)$/, ''

# Displays an indicator and tooltips to the user about the current status
setStatus: (status="", message="") =>
Expand Down
Loading