Conversation
ghost
assigned
2 tasks
Contributor
Author
Contributor
Author
|
@ecorpnu here ya go |
stickler-ci
reviewed
Jul 2, 2018
app/assets/v2/js/tokens.js
Outdated
| { 'addr': '0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466', 'name': 'AION', 'decimals': 8 }, | ||
| { 'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18 } | ||
| { 'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18 }, | ||
| { "addr": "0x7338809d1a2c6fbb6e755470ab2a28e8c5dac63c", "name": "OZR", "decimals": 18}, |
There was a problem hiding this comment.
Strings must use singlequote. (quotes)
Unexpected trailing comma. (comma-dangle)
app/assets/yge/youvegoteth/tokens.js
Outdated
| {'addr': '0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466', 'name': 'AION', 'decimals': 8}, | ||
| {'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18} | ||
| {'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18}, | ||
| {"addr": "0x7338809d1a2c6fbb6e755470ab2a28e8c5dac63c", "name": "OZR", "decimals": 18}, |
There was a problem hiding this comment.
Strings must use singlequote. (quotes)
Unexpected trailing comma. (comma-dangle)
ecorpnu
suggested changes
Jul 3, 2018
ecorpnu
left a comment
ecorpnu
left a comment
There was a problem hiding this comment.
I made a mistake it should be single quote not double .
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
==========================================
- Coverage 29.93% 29.82% -0.12%
==========================================
Files 130 130
Lines 9596 9766 +170
Branches 1243 1297 +54
==========================================
+ Hits 2873 2913 +40
- Misses 6619 6743 +124
- Partials 104 110 +6
Continue to review full report at Codecov.
|
mbeacom
approved these changes
Jul 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per @ecorpnu request