Fix the cURL problem identified in microsoft/git via t5799.13(curl-connect: no server) failures
#163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cURL v8.16.0, the behavior changed subtly: Timeouts were added even in circumstances where cURL failed to connect and should have errored out with the corresponding
CURLE_COULDNT_CONNECTinstead.This has been identified in
microsoft/gitvia test failures in t5799:It is a bit difficult to diagnose the problem from Git's output, as the interesting information is suppressed: Instead of
curl:7(CURLE_COULDNT_CONNECT), it reportscurl:28(CURLE_OPERATION_TIMEDOUT). I reported this to the cURL project and they gracefully jumped on fixing it. This here PR back-ports the fix from curl/curl#18768.