install-from-source.sh: fix libssl Alpine pkgs #1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of libssl available in the Alpine package feeds changed with version 3.15. The latest libssl package is 1.1 in 3.14.x and earlier, but newer versions only have libssl3. Add a check for the Alpine version in the install from source script and switch between installing libssl3 and libssl1.1 depending on the distro version. Also add another entry to the test matrix of distributions to include a 3.14.x Alpine version.
This was referenced Apr 16, 2024
ldennington
reviewed
Apr 16, 2024
ldennington
approved these changes
Apr 16, 2024
Merged
mjcheetham
added a commit
that referenced
this pull request
Apr 16, 2024
**Changes:** - Fixes to install from source script (#1469) - Use Avalonia generated view code (#14790 - Various GitHub Actions updates (#1473, #1483, #1487, #1486, #1488, #1528, #1547) - Fix bug in Azure Repos URL handling (#1522) - Add Azure Managed Identity and SP docs (#1548) - Fix error messages when using GCM outside of repo (#1561, #1583) - Remove ESRP (#1571) - Update to .NET 8 for Mac and Linux (#1579, #1580) - Fix Alpine install from source script (#1582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of libssl available in the Alpine package feeds changed with version 3.15. The latest libssl package is 1.1 in 3.14.x and earlier, but newer versions only have libssl3.
Add a check for the Alpine version in the install from source script and switch between installing libssl3 and libssl1.1 depending on the distro version.
Also add another entry to the test matrix of distributions to include a 3.14.x Alpine version.
This replaces the two other PRs that aimed to address this issue:
Tested the updated workflow here: https://github.com/git-ecosystem/git-credential-manager/actions/runs/8698286553/job/23855027830