Skip to content

build(deps): upgrade github.com/bytedance/sonic from v1.13.2 to v1.14.0#4342

Merged
appleboy merged 4 commits intogin-gonic:masterfrom
flc1125:upgrade-sonic
Sep 19, 2025
Merged

build(deps): upgrade github.com/bytedance/sonic from v1.13.2 to v1.14.0#4342
appleboy merged 4 commits intogin-gonic:masterfrom
flc1125:upgrade-sonic

Conversation

@flc1125
Copy link
Contributor

@flc1125 flc1125 commented Aug 31, 2025

Dependencies for supporting Go 1.25: #4341

@flc1125 flc1125 mentioned this pull request Aug 31, 2025
@codecov
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.92%. Comparing base (3dc1cd6) to head (565f245).
⚠️ Report is 164 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4342      +/-   ##
==========================================
- Coverage   99.21%   98.92%   -0.30%     
==========================================
  Files          42       44       +2     
  Lines        3182     3438     +256     
==========================================
+ Hits         3157     3401     +244     
- Misses         17       26       +9     
- Partials        8       11       +3     
Flag Coverage Δ
?
--ldflags="-checklinkname=0" -tags sonic 98.91% <ø> (?)
-tags go_json 98.85% <ø> (?)
-tags nomsgpack 98.90% <ø> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 ?
go-1.23 98.92% <ø> (?)
go-1.24 98.92% <ø> (?)
macos-latest 98.92% <ø> (-0.30%) ⬇️
ubuntu-latest 98.92% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@flc1125 flc1125 marked this pull request as draft August 31, 2025 08:02
// https://github.com/bytedance/sonic/issues/800
var expectedCode int
switch json.Package {
case "github.com/goccy/go-json", "github.com/bytedance/sonic":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flc1125 flc1125 marked this pull request as ready for review August 31, 2025 08:12
@appleboy appleboy requested a review from Copilot September 13, 2025 23:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the github.com/bytedance/sonic JSON library from v1.13.2 to v1.14.0 to support Go 1.25 compatibility. The upgrade also brings in updated transitive dependencies and removes sonic-specific workarounds in test code.

  • Upgrades sonic library to v1.14.0 along with related transitive dependencies
  • Updates test expectations to remove sonic-specific behavior workarounds
  • Aligns dependency versions for Go 1.25 support

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
go.mod Updates sonic and transitive dependencies to newer versions
context_test.go Removes sonic-specific test case handling for http.MaxBytesError

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@appleboy appleboy added this to the v1.11 milestone Sep 19, 2025
@appleboy appleboy merged commit da372fc into gin-gonic:master Sep 19, 2025
24 of 25 checks passed
@flc1125 flc1125 deleted the upgrade-sonic branch September 19, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants