elf: add read and write support for GNU properties #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
force-pushed
the
elf-gnu-prop
branch
3 times, most recently
from
26ded31 to
e91df1d
Compare
Merged
cchiw
reviewed
Jul 11, 2023
| let n_name = b"GNU\0"; | ||
| data.extend_from_slice(pod::bytes_of(&elf::NoteHeader32 { | ||
| n_namesz: U32::new(self.endian, n_name.len() as u32), | ||
| n_descsz: U32::new(self.endian, util::align(3 * 4, align) as u32), |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
It needs to be 12 for 32-bit and 16 for 64-bit. The expression util::align(3 * 4, align) should handle that.
| // Value size | ||
| data.extend_from_slice(pod::bytes_of(&U32::new(self.endian, 4))); | ||
| data.extend_from_slice(pod::bytes_of(&U32::new(self.endian, value))); | ||
| util::write_align(&mut data, align); |
Contributor
There was a problem hiding this comment.
Is it typical to not include padding information if it's 0? #learning
Contributor
Author
There was a problem hiding this comment.
I'm not sure I understand what you mean. util::write_align(&mut data, align) is the padding, which may be either 0 or 4 bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.