Ada delta fix#4
Merged
gigasquid merged 2 commits intogigasquid:masterfrom Jun 14, 2018
khryniewicz:ada-delta-fix
Merged
Conversation
added 2 commits
June 13, 2018 15:42
Owner
|
Thanks so much! 😸 |
Owner
|
I added you to the thanks section of the README - please let me know if you need any changes I also ported the bug fix over to the PR branch here to the main project and gave you credit in the commit message apache/mxnet#11205 Thanks again for your contribution. Also, we are looking for Clojure help to review the PR in the main project, so if you are interested, feel free to get involved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried using
ada-deltaas optimizer, but ended up with StackOverflow error, coused by bad parentheses inoptimizer.clj.While I was there i noticed theres mismatched citation of
ada-gradoptimizer both here and in Scala MXNet. I added proper one there too.