Skip to content

Conversation

@ghiscoding
Copy link
Owner

  • in order to depend less on the use of innerHTML, we should convert internal code that have Formatter to use native HTML element to be more CSP compliant. However please note that the user will have to convert themselve the GroupTotals Formatter to native element as well for full CSP compliance on that section of the code

- in order to depend less on the use of innerHTML, we should convert internal code that have Formatter to use native HTML element to be more CSP compliant. However please note that the user will have to convert themselve the GroupTotals Formatter to native element as well for full CSP compliance on that section of the code
@codecov
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (cf3254d) 86.12% compared to head (fcf3a35) 86.11%.
Report is 4 commits behind head on next.

Files Patch % Lines
packages/common/src/core/slickGrid.ts 50.00% 5 Missing ⚠️
...n/src/extensions/slickGroupItemMetadataProvider.ts 91.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1215      +/-   ##
==========================================
- Coverage   86.12%   86.11%   -0.01%     
==========================================
  Files         208      208              
  Lines       21229    21239      +10     
  Branches     7060     7063       +3     
==========================================
+ Hits        18281    18287       +6     
- Misses       2948     2952       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit d723856 into next Nov 24, 2023
@ghiscoding ghiscoding deleted the chore/group-itemmetada-native-element branch November 24, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants