Skip to content

fix: cherry-pick from forks, finally#24

Open
lishaduck wants to merge 4 commits intomasterfrom
fixes
Open

fix: cherry-pick from forks, finally#24
lishaduck wants to merge 4 commits intomasterfrom
fixes

Conversation

@lishaduck
Copy link
Member

@lishaduck lishaduck commented Mar 19, 2026

As often promised, this cherry-picks a bunch of PRs from the @lowlighter repository.
I've reviewed them manually but haven't had experience with any of the listed bugs myself, so I selected what seemed to be the best patch from among the PRs. I took a look at the obviously Claude Code/etc PRs as well, but did not attribute their authors as they didn't seem to contribute anything unique that a human hadn't already written.

Closes #21.

CC: @dkhokhlov @austenstone @EndBug @oddstr13 @felipecrs @ferferga
Can I get a one or two of y'all to test this branch and make sure it works?

Co-authored-by: Dmitri Khokhlov <[email protected]>
Co-authored-by: Austen Stone <[email protected]>
Co-authored-by: Federico Grandi <[email protected]>
Co-authored-by: Odd Stråbø <[email protected]>
Co-authored-by: Felipe Santos <[email protected]>
Co-authored-by: Fernando Fernández <[email protected]>
@github-actions

This comment has been minimized.

Copy link

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep commits intact.

At the very least, keep one commit per contributing person.

I am not happy with the way attribution is getting squished here.

I won't be testing this PR, as I decided it wasn't worth my time to figure out the new errors that showed up (and caused failure email notifications to be generated), and as such disabled it on my profile a while back.

@oddstr13
Copy link

Ideally, you would merge in the individual branches that you are cherry-picking from here, keeping all commits with their original commit info. GitHub has instructions for how to merge a commit on the command line, and these instructions can be used to merge changes even tho a particular tree/PR isn't targeted at your own repository.

It is also a good idea to link back to the specific PRs that are included in a combination PR such as this one.

For example, my changes exist here; lowlighter#1754

This helps maintain the context of how and why changes are made, along with who and what comments it has received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants