feat: Remove limitation on PRs modifying "repository" files#17
Merged
lishaduck merged 4 commits intogh-metrics:masterfrom Dec 20, 2025
Merged
Conversation
jayvdb
commented
Dec 20, 2025
Comment on lines
-3264
to
-3265
| "node_modules/canvas": { | ||
| "version": "2.11.2", |
Author
There was a problem hiding this comment.
interesting - I did an npm install , and this was removed
% npm --version
11.6.2
Member
There was a problem hiding this comment.
Metrics v3 is still on Node.js 20, which ships with npm 10.
Not really sure why new npm drops canvas though, we hit it in #16.
Closed
Member
|
While I would've preferred you to have filed an issue, you lucked out cuz I haven't finished #13... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The limitation on who can touch which files is not necessary at the moment, and counter productive.
Perhaps when there is an active maintenance team, some limits might be appropriate again.