Skip to content

llava : fix occasional undefined behavior crash#9078

Open
jart wants to merge 1 commit intoggml-org:masterfrom
jart:clip
Open

llava : fix occasional undefined behavior crash#9078
jart wants to merge 1 commit intoggml-org:masterfrom
jart:clip

Conversation

@jart
Copy link
Copy Markdown
Contributor

@jart jart commented Aug 18, 2024

Nice simple bug fix for you.

@fairydreaming
Copy link
Copy Markdown
Collaborator

Just wanted to note that this is yet another solution that fixes #9066 by zero-initializing the load_image_size field of the clip_ctx structure. PR #9082 does the same, but zero-initializes all clip_ctx fields that have no default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: MiniCPM-V-2.6 commit d565bb2fd5a2a58b9924a7a34e77a87c78c52137 causing crash in moondream

2 participants