cuda : update supports_op for matrix multiplication#8245
Merged
Conversation
ggerganov
approved these changes
Jul 2, 2024
Nexesenex
pushed a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 2, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
supports_opto correctly reflect that bf16 is not supported, and prevent new types added in the future from being incorrectly reported as supported. This will also cause bf16 models to be run on the CPU rather than crashing when using a CUDA build.