vulkan: detect multiple devices by deviceUUID instead of deviceID#8022
Merged
0cc4m merged 3 commits intoggml-org:masterfrom Jun 21, 2024
Merged
vulkan: detect multiple devices by deviceUUID instead of deviceID#80220cc4m merged 3 commits intoggml-org:masterfrom
0cc4m merged 3 commits intoggml-org:masterfrom
Conversation
mofosyne
added
the
Review Complexity : Low
0cc4m
requested changes
Jun 20, 2024
Contributor
0cc4m
left a comment
0cc4m
left a comment
There was a problem hiding this comment.
I tested it and it works. I just have a few small comments about the code style, once you addressed those this can be merged.
Contributor
Author
|
@0cc4m ok done |
Adriankhl
force-pushed
the
fix-vulkan-deviceID
branch
from
e4e0d09 to
2f290b5
Compare
0cc4m
requested changes
Jun 20, 2024
Contributor
0cc4m
left a comment
0cc4m
left a comment
There was a problem hiding this comment.
I'm not sure how I missed that, it seemed to be working before. You need to actually fill the old_id.
0cc4m
approved these changes
Jun 21, 2024
Contributor
0cc4m
left a comment
0cc4m
left a comment
There was a problem hiding this comment.
Thank you, now it's working as intended!
HoiV
added a commit
to HoiV/llama_dc.cpp
that referenced
this pull request
Jun 24, 2024
Update hv/matmul up to: commit 557b653 (HEAD -> master, origin/master, origin/HEAD) Author: k.h.lai <adrian.k.h.lai@outlook.com> Date: Fri Jun 21 16:28:20 2024 +0800 vulkan: detect multiple devices by deviceUUID instead of deviceID (ggml-org#8022) commit 7d5e877 Author: Eve <139727413+netrunnereve@users.noreply.github.com> Date: Fri Jun 21 05:57:36 2024 +0000 ggml : AVX IQ quants (ggml-org#7845) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7997