Skip to content

Update convert-hf-to-gguf.py#8015

Merged
Galunid merged 2 commits intoggml-org:masterfrom
0xspringtime:master
Jun 22, 2024
Merged

Update convert-hf-to-gguf.py#8015
Galunid merged 2 commits intoggml-org:masterfrom
0xspringtime:master

Conversation

@0xspringtime
Copy link
Copy Markdown
Contributor

Replacing with a less risky alternative to the 'assert' statement

Replacing with a less risky alternative to the 'assert' statement
@github-actions github-actions bot added the python python script changes label Jun 19, 2024
Copy link
Copy Markdown
Contributor Author

@0xspringtime 0xspringtime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax correction

@mofosyne mofosyne added Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. and removed merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. labels Jun 19, 2024
@Galunid Galunid merged commit 3aa184a into ggml-org:master Jun 22, 2024
@HanClinto
Copy link
Copy Markdown
Contributor

Too many blank lines were added on line 977-ish, so it's now breaking CI. Not a huge deal, but wanted to let you know. I will fix in another PR.

Make sure to double-check failing CI steps before merging. Sometimes build failures are fine (like the finicky Docker builds), but things like the Lint check should always pass. Always double-check failures to ensure that they're not caused by the PR prior to merging.

@HanClinto
Copy link
Copy Markdown
Contributor

I'm also not sure how the CI treats Python-only changes, and it's possible that CI didn't run until merge, so it might not have been easy to see this one.

@Galunid
Copy link
Copy Markdown
Contributor

Galunid commented Jun 22, 2024

My bad, sorry about that and thanks for fixing!

@HanClinto
Copy link
Copy Markdown
Contributor

My bad, sorry about that and thanks for fixing!

No worries! Looking at it now, I'm really not sure if the CI ran prior to the merge or not, so I don't know if there was a way you reasonably could have caught it.

We may need to modify the CI triggers on Python-only changes -- I'm really not sure.

Either way, not a big deal. I've made my share of merge hiccups, and it's just something to take in stride. :)

Thanks for being pro-active with reviews and merges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants