Skip to content

llava : use logger in llava-cli#6797

Merged
ggerganov merged 1 commit intoggml-org:masterfrom
jart:llava-printf2
Apr 21, 2024
Merged

llava : use logger in llava-cli#6797
ggerganov merged 1 commit intoggml-org:masterfrom
jart:llava-printf2

Conversation

@jart
Copy link
Copy Markdown
Contributor

@jart jart commented Apr 20, 2024

This change removes printf() logging so llava-cli is shell scriptable.

This change removes printf() logging so llava-cli is shell scriptable.
@dagelf
Copy link
Copy Markdown

dagelf commented Apr 21, 2024

👋 Forgive my ignorance 😄 How is that different? What's wrong with 2> llama.log?

@ggerganov ggerganov merged commit 89b0bf0 into ggml-org:master Apr 21, 2024
@jart
Copy link
Copy Markdown
Contributor Author

jart commented Apr 21, 2024

@dagelf in most cases llava was actually logging to stdout.

@sorasoras
Copy link
Copy Markdown

@jart this break rocm compile on windows
debugbuild.txt
Can you take a look?

@dagelf
Copy link
Copy Markdown

dagelf commented Apr 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants