Skip to content

minor layout improvements#6572

Merged
phymbert merged 3 commits intoggml-org:masterfrom
rsoika:master
Apr 10, 2024
Merged

minor layout improvements#6572
phymbert merged 3 commits intoggml-org:masterfrom
rsoika:master

Conversation

@rsoika
Copy link
Copy Markdown
Contributor

@rsoika rsoika commented Apr 9, 2024

This is a minor layout improvement. I only added some CSS definitions and a smaller fix in the script to display the chat buttons:

Before:

grafik

After:

grafik

@phymbert
Copy link
Copy Markdown
Collaborator

phymbert commented Apr 9, 2024

Hi, thanks, you need to run the deps.sh

@phymbert
Copy link
Copy Markdown
Collaborator

phymbert commented Apr 9, 2024

@rsoika maybe it was not clear: static assets are converted to *.cpp generated sources and embedded in the server binary.

See the CI server workflow:
Run locally deps.sh and commit the generated changes.

@github-actions

This comment was marked as off-topic.

@phymbert phymbert merged commit b3a96f2 into ggml-org:master Apr 10, 2024
@ggerganov
Copy link
Copy Markdown
Member

I'm not very happy with this change. Here is what is looks in my setup (left is new, right is old):

image

Here are some recommendations:

  • The active text in the textboxes should remain with high contrast as before
  • The color of the buttons should match the color of the sliders (in my case green)
  • No need to increase the font-size in the inputs (or at least not so prominently)

phymbert added a commit that referenced this pull request Apr 15, 2024
@rsoika
Copy link
Copy Markdown
Contributor Author

rsoika commented Apr 15, 2024

If you do not like it you can roll it back.
Or we remove

color: #666;
font-size: 1.1rem;

and add the slider color
input[type='range']{ accent-color: #3584e4; }

@phymbert
Copy link
Copy Markdown
Collaborator

@rsoika Sorry I do not use the server web ui myself, I was wrongly thinking the proposed changes were OK for everyone.

Feel free to reopen a PR with recommandations provided by @ggerganov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants