chat : detect reasoning markers when enable_thinking changes system prompt#20859
Merged
pwilkin merged 1 commit intoggml-org:masterfrom Mar 23, 2026
Merged
chat : detect reasoning markers when enable_thinking changes system prompt#20859pwilkin merged 1 commit intoggml-org:masterfrom
pwilkin merged 1 commit intoggml-org:masterfrom
Conversation
Member
|
#20424 should have fixed it. |
Collaborator
Author
@pwilkin There are the results I got for So |
pwilkin
approved these changes
Mar 23, 2026
Member
pwilkin
left a comment
There was a problem hiding this comment.
Ah, I'm sorry, I was tired and I look at the description and thought it was for something else before looking at the code.
Yes, this is valid, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found models like SmolLM3-3B chat template changes the system prompt depends on
enable_thinking(!left_trimmed.empty() && !right_trimmed.empty()), so it will skip parse the reasoning markers.Codex (gpt-5.4, xhigh) also helped check this bug fix.