Merged
Conversation
danbev
approved these changes
Mar 9, 2026
Member
|
Will check. |
Member
|
@ggerganov the default chat template is broken, cuts off the last tool call (which also breaks the analysis). Works fine with the one from |
Member
|
BTW, I'm wondering if we should detect broken templates and use the ones from the |
Member
Author
|
Ok, even just a warning in the logs would be useful. |
Contributor
|
It seems I misinterpreted how the values are being used, thank you for fixing it. |
bartowski1182
pushed a commit
to bartowski1182/llama.cpp
that referenced
this pull request
Mar 10, 2026
Ethan-a2
pushed a commit
to Ethan-a2/llama.cpp
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cont #19802
fix #20268
This fixes the model loading, but the reasoning parsing seems to be broken because the post-reasoning contents are not being displayed in the WebUI:
cc @pwilkin