tools : use common_log_pause to fix fit-params output race#18276
Merged
ngxson merged 1 commit intoggml-org:masterfrom Dec 24, 2025
Merged
tools : use common_log_pause to fix fit-params output race#18276ngxson merged 1 commit intoggml-org:masterfrom
ngxson merged 1 commit intoggml-org:masterfrom
Conversation
ngxson
reviewed
Dec 22, 2025
Contributor
ngxson
left a comment
There was a problem hiding this comment.
you should use log_flush instead
43d8911 to
af90d0d
Compare
af90d0d to
ed29873
Compare
Contributor
Author
|
changed |
ngxson
approved these changes
Dec 24, 2025
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the
std::this_thread::sleep_for(10ms)hack withcommon_log_pause(common_log_main())inllama-fit-params.Reasoning:
The previous 10ms delay was intended to let the async logger drain its queue to
stderrbefore the main thread printed the result tostdout. However, on high-performance or loaded systems, 10ms is not guaranteed to be enough, leading to interleaved output (see Issue #18085).common_log_pauseexplicitly waits for the background worker to drain the log queue, ensuring deterministic separation between logs and the final result.Fixes #18085